Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify non-GKE resources map to k8s_* monitored resources #258

Closed
damemi opened this issue Jul 26, 2023 · 3 comments · Fixed by #340
Closed

Verify non-GKE resources map to k8s_* monitored resources #258

damemi opened this issue Jul 26, 2023 · 3 comments · Fixed by #340
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request good first issue Good for newcomers priority: p2

Comments

@damemi
Copy link
Contributor

damemi commented Jul 26, 2023

From GoogleCloudPlatform/opentelemetry-operations-go#627, verify that kubernetes resources do not require cloud.platform: gcp_kubernetes_engine to map to k8s Monitored Resources (k8s_container, k8s_pod, etc).

Go exporter/collector fix in GoogleCloudPlatform/opentelemetry-operations-go#683 uses k8s.cluster.name resource attribute to identify a k8s resource. Other languages should be consistent with this.
@aabmass aabmass added enhancement New feature or request good first issue Good for newcomers priority: p2 enhancement accepted An actionable enhancement for which PRs will be accepted labels Jul 31, 2023
@aabmass
Copy link
Contributor

aabmass commented Jul 31, 2023

Triaged. If anyone would like to work on this please leave a comment.

tkmsaaaam added a commit to tkmsaaaam/opentelemetry-operations-java that referenced this issue May 6, 2024
@tkmsaaaam
Fix GoogleCloudPlatform#258 enable mapping when not gcp kubernetes
e5f4d84
@tkmsaaaam tkmsaaaam mentioned this issue May 6, 2024
Merged
@tkmsaaaam
Copy link
Contributor

I created this PR. #340 Please review it.

psx95 added a commit to psx95/opentelemetry-operations-java that referenced this issue May 10, 2024
@psx95
Merge pull request #3 from tkmsaaaam/fix-issue-258
4dc330c 
Add changes from fix for Issue GoogleCloudPlatform#258
psx95 added a commit that referenced this issue May 10, 2024
@tkmsaaaam @psx95
Fix #258 enable mapping when not gcp kubernetes (#340)
77ac82a 
* Fix #258 enable mapping when not gcp kubernetes

* fix code style

* added comment for posterity

* Added label's mappings each mr_type

* Update to JUnit5 and refactor with ParameterizedTest

* Update code style for test

* Fix code style

---------

Co-authored-by: Pranav Sharma <sharmapranav@google.com>
@tkmsaaaam
Copy link
Contributor

My apologize. I fixed this issue. But I noticed it contained bug. So I fixed it. Please review it.
#342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request good first issue Good for newcomers priority: p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #258 enable mapping when not gcp kubernetes tkmsaaaam/opentelemetry-operations-java
3 participants
@aabmass @damemi @tkmsaaaam