Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP / DO NOT MERGE] Make functions/ tests region-tag based #1292

Closed
wants to merge 13 commits into from

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 17, 2019

Do not merge until:
a) the other functions/ tests are covered, and
b) I've finalized an MVP of said analytics on our (internal) backend

Moving functions samples to region-tag-based tests to make analytics easier.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2019
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@ace-n ace-n changed the title [WIP] Make functions/ tests region-tag based [WIP / DO NOT MERGE] Make functions/ tests region-tag based May 17, 2019
@fhinkel fhinkel added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 17, 2019

Are you still working on this PR or can we close it?

@ace-n
Copy link
Contributor Author

ace-n commented Jul 17, 2019 via email

@ace-n
Copy link
Contributor Author

ace-n commented Oct 14, 2019

Closed in favor of #1499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants