Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip *_BetaBasicHandWritten tests that are consistently failing #8476

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Jul 28, 2023

These tests have been failing for a while in the nightly runs, and I've seen them creating noise in PRs as well. Skipping while we work out a resolution.

Related failures: hashicorp/terraform-provider-google#14085, hashicorp/terraform-provider-google#14392

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 3 files changed, 881 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2887
Passed tests 2585
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@roaks3 roaks3 requested a review from shuyama1 July 28, 2023 15:44
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Let's skip these tests for now

@shuyama1 shuyama1 merged commit 2a0393a into main Aug 2, 2023
@shuyama1 shuyama1 deleted the skip-failing-multicloud-tests branch August 2, 2023 00:33
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Aug 3, 2023
ostrain added a commit to ostrain/magic-modules that referenced this pull request Aug 8, 2023
zli82016 pushed a commit that referenced this pull request Aug 8, 2023
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants