dns: Support Routing Policy in DNS Record Set

[kanata2]

Description

This PR implements Routing Policy in Cloud DNS's Record Set.

fixes hashicorp/terraform-provider-google#11038

Status

Reviewable. If you have an opinion about the API design, please let me know.

---

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

---

Release Note Template for Downstream PRs (will be copied)

dns: added `routing_policy` to `google_dns_record_set` resource

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@shuyama1, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 241 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 1 file changed, 241 insertions(+), 29 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1972
Passed tests 1728
Skipped tests: 238
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccDNSRecordSet_routingPolicy|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[view]
TestAccContainerCluster_withAuthenticatorGroupsConfig[view]

Tests failed during RECORDING mode:
TestAccAccessContextManager[view]
TestAccDNSRecordSet_routingPolicy[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1972
Passed tests 1730
Skipped tests: 238
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccDNSRecordSet_routingPolicy|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccDNSRecordSet_routingPolicy[view]

All tests passed
View the build log or the debug log for each test

[kanata2]

Hi, @shuyama1
This PR is now ready for review.
Could you please check when you are available?

[kanata2]

@shuyama1 Sorry to bother you again. I really need this feature, is there any plan to release it soon...? 😭

[polaru]

My company is also waiting for this to go live. :)

[shuyama1]

@kanata2 So sorry for the delay on this. Working on reviewing it now and will post my comment asap!

[shuyama1]

Question: any reason that we want to name this field region instead of location(aligned with api)?

[kanata2]

The actual value to be specified is region, so I named it region.(however I will change it to location.)

[kanata2]

renamed!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1989
Passed tests 1746
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[kanata2]

@shuyama1
Fixed.
The failure of TestAccServiceNetworkingPeeredDNSDomain_basic seems not to be related with this PR 🤔

[shuyama1]

Looks like the failing test TestAccServiceNetworkingPeeredDNSDomain_basic is not related. Running some local tests now.

[shuyama1]

Running VCR for the last time and will merge it if no related tests fail
/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 3 files changed, 394 insertions(+), 34 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1995
Passed tests 1752
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]

All tests passed
View the build log or the debug log for each test

[shuyama1]

Thank you so much for your contribution!