Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metastore dataproc service data source #5763

Merged
merged 9 commits into from
Mar 28, 2022

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Feb 28, 2022

Closes hashicorp/terraform-provider-google#10462

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc_metastore_service

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@megan07, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 4 insertions(+))
Terraform Beta: Diff ( 2 files changed, 75 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@DrFaust92 DrFaust92 force-pushed the metastore-datasource branch from 50489fe to 5425706 Compare March 17, 2022 14:50
@megan07
Copy link
Contributor

megan07 commented Mar 24, 2022

Hi @DrFaust92 , I had a chance to review this and run the tests locally. I think the only things missing here would be to add this datasource to the provider: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/utils/provider.go.erb#L259 and add some documentation. Thanks!

@DrFaust92 DrFaust92 force-pushed the metastore-datasource branch from 5425706 to c326936 Compare March 24, 2022 18:12
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 54 insertions(+))
Terraform Beta: Diff ( 5 files changed, 126 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 53 insertions(+))
Terraform Beta: Diff ( 5 files changed, 125 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@DrFaust92
Copy link
Contributor Author

Thanks @megan07, made some change and tested now.

--- PASS: TestAccDataprocMetastoreServiceDatasource_basic (861.13s)

@DrFaust92 DrFaust92 marked this pull request as ready for review March 24, 2022 21:28
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 54 insertions(+))
Terraform Beta: Diff ( 5 files changed, 126 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@megan07
Copy link
Contributor

megan07 commented Mar 25, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 54 insertions(+))
Terraform Beta: Diff ( 5 files changed, 126 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreServiceDatasource_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=272816

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and tests pass! If you wouldn't mind changing that test name, that'd be great! Thanks!

func TestAccDataprocMetastoreServiceDatasource_basic(t *testing.T) {
t.Parallel()

name := "tf-metastore-" + randString(t, 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I missed this yesterday. Would you mind changing the name here to begin with tf-test please? We have sweepers that will clean up old test resources that may linger that are prefixed with that. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megan07 done 👍

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 54 insertions(+))
Terraform Beta: Diff ( 5 files changed, 126 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* metastore dataproc service data source

* provider

* docs

* test name

* location optional

* revert location and make required

* docs

* docs

* tf test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add datasource for google_dataproc_metastore_service
3 participants