-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metastore dataproc service data source #5763
metastore dataproc service data source #5763
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @megan07, please review this PR or find an appropriate assignee. |
50489fe
to
5425706
Compare
Hi @DrFaust92 , I had a chance to review this and run the tests locally. I think the only things missing here would be to add this datasource to the provider: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/utils/provider.go.erb#L259 and add some documentation. Thanks! |
5425706
to
c326936
Compare
Thanks @megan07, made some change and tested now. --- PASS: TestAccDataprocMetastoreServiceDatasource_basic (861.13s) |
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreServiceDatasource_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=272816 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and tests pass! If you wouldn't mind changing that test name, that'd be great! Thanks!
func TestAccDataprocMetastoreServiceDatasource_basic(t *testing.T) { | ||
t.Parallel() | ||
|
||
name := "tf-metastore-" + randString(t, 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! I missed this yesterday. Would you mind changing the name here to begin with tf-test
please? We have sweepers that will clean up old test resources that may linger that are prefixed with that. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@megan07 done 👍
* metastore dataproc service data source * provider * docs * test name * location optional * revert location and make required * docs * docs * tf test
Closes hashicorp/terraform-provider-google#10462
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)