-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate template field to privateca Certificate #5135
Conversation
…authority is present in TF. Also adds test - which will only successfully run in CI since it depends on a static CA pool.
Hm, well, it compiles, but seems to have failed to trigger recording mode. Odd. |
Error trying to cancel build () |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202788 |
Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR |
Ahh... I think I've got it - the field needs comparison ignoring project number / name disparities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me!
…latform#5135) * Add certificate authority field to Certificate, now that certificate authority is present in TF. Also adds test - which will only successfully run in CI since it depends on a static CA pool. * compare resource names instead, because we have a project number.
Now that privateca certificate template is present in TF.
Also adds test - which will only successfully run in CI since it depends on a static CA pool.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.(note that tests will have to run on this PR overnight, since the privateca resources are hard to test and depend on a certificate pool that's set up statically).
Fixes hashicorp/terraform-provider-google#9792.
Release Note Template for Downstream PRs (will be copied)