Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate template field to privateca Certificate #5135

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

nat-henderson
Copy link
Contributor

Now that privateca certificate template is present in TF.

Also adds test - which will only successfully run in CI since it depends on a static CA pool.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

(note that tests will have to run on this PR overnight, since the privateca resources are hard to test and depend on a certificate pool that's set up statically).

Fixes hashicorp/terraform-provider-google#9792.

Release Note Template for Downstream PRs (will be copied)

`privateca`: Added `certificate_template` to `google_privateca_certificate`.

…authority is present in TF.

Also adds test - which will only successfully run in CI since it depends on a static CA pool.
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 315 insertions(+))
Terraform Beta: Diff ( 4 files changed, 316 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@nat-henderson
Copy link
Contributor Author

Hm, well, it compiles, but seems to have failed to trigger recording mode. Odd.
/gcbrun
We'll rerun and see what happens.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 315 insertions(+))
Terraform Beta: Diff ( 4 files changed, 316 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202788

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR

@nat-henderson
Copy link
Contributor Author

Ahh... I think I've got it - the field needs comparison ignoring project number / name disparities.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 315 insertions(+))
Terraform Beta: Diff ( 3 files changed, 315 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@nat-henderson
Copy link
Contributor Author

@nat-henderson nat-henderson requested review from a team and slevenick and removed request for a team August 25, 2021 22:11
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@nat-henderson nat-henderson merged commit 4d07dbc into master Aug 25, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…latform#5135)

* Add certificate authority field to Certificate, now that certificate authority is present in TF.

Also adds test - which will only successfully run in CI since it depends on a static CA pool.

* compare resource names instead, because we have a project number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support certificateTemplate field in google_privateca_certificate
3 participants