Apigee organization

[drebes]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_apigee_organization

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1197 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1197 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 112 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163291"

[drebes]

$ make testacc TEST=./google-beta TESTARGS='-run=TestAccApigeeOrganization_apigeeOrganization'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccApigeeOrganization_apigeeOrganization -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample
=== PAUSE TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample
=== RUN   TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample
=== PAUSE TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample
=== CONT  TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample
=== CONT  TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample
--- PASS: TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample (445.97s)
--- PASS: TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample (479.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/v3/google-beta	479.945s

[c2thorn]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1197 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1197 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 112 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=163292"

[c2thorn]

MM seems to be generating this example in the GA provider (causing CI build errors), and it isn't clear to me why. The configuration here looks correct. I'm looking to see if there is a potential MM bug

[drebes]

I found the issue in the test template. Since Apigee has no beta API, and the template takes the minimum version of the API min_version and not of the example, this generates the test for the GA version of the provider. I'm not fluent enough in Ruby to fix that, but a workaround is to define a beta version of the API with the same v1 endpoint. I'll push a commit with that, but will gladly change if you can find a way to fix the test template instead.

[drebes]

I tried to open an issue in the MM repo but I can only open provider specific issues from there.

[c2thorn]

There's not a great place to file this, but I made one in the google provider repo where it will actually get monitored: hashicorp/terraform-provider-google#8174

Thanks for looking into this

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1078 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1222 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 112 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166227"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=166228"

[c2thorn]

LGTM, build and tests pass now. Thanks!