Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rigm to upgrade guide #2667

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add rigm to upgrade guide #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions third_party/terraform/website/docs/guides/version_3_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,14 @@ so Terraform knows to manage them.
- [Resource: `google_compute_health_check`](#resource-google_compute_health_check)
- [Resource: `google_compute_image`](#resource-google_compute_image)
- [Resource: `google_compute_instance`](#resource-google_compute_instance)
- [Resource: `google_compute_instance_group_manager`](#resource-google_compute_instance_group_manager)
- [Resource: `google_compute_instance_template`](#resource-google_compute_instance_template)
- [Resource: `google_compute_network`](#resource-google_compute_network)
- [Resource: `google_compute_network_peering`](#resource-google_compute_network_peering)
- [Resource: `google_compute_node_template`](#resource-google_compute_node_template)
- [Resource: `google_compute_region_backend_service`](#resource-google_compute_region_backend_service)
- [Resource: `google_compute_region_health_check`](#resource-google_compute_region_health_check)
- [Resource: `google_compute_region_instance_group_manager`](#resource-google_compute_region_instance_group_manager)
- [Resource: `google_compute_region_instance_group_manager`](#resource-google_compute_instance_group_manager)
- [Resource: `google_compute_resource_policy`](#resource-google_compute_resource_policy)
- [Resource: `google_compute_route`](#resource-google_compute_route)
- [Resource: `google_compute_router`](#resource-google_compute_router)
Expand Down Expand Up @@ -615,6 +616,52 @@ is now required on `google_compute_instance.scheduling`
In an attempt to avoid allowing empty blocks in config files, at least one of `on_host_maintenance`, `automatic_restart`,
`preemptible`, or `node_affinities` is now required on the `scheduling` block.

## Resource: `google_compute_instance_group_manager`

The following changes apply to both `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`.

### `instance_template` has been replaced by `version.instance_template`

Instance group managers should be using `version` blocks to reference which
instance template to use for provisioning. To upgrade use a single `version`
block with `instance_template` in your config and by default all traffic will be
directed to that version.

### Old Config

```hcl
resource "google_compute_instance_group_manager" "my_igm" {
name = "my-igm"
zone = "us-central1-c"
base_instance_name = "igm"

instance_template = "${google_compute_instance_template.my_tmpl.self_link}"
}
```

### New Config

```hcl
resource "google_compute_instance_group_manager" "my_igm" {
name = "my-igm"
zone = "us-central1-c"
base_instance_name = "igm"

version {
name = "prod"
instance_template = "${google_compute_instance_template.my_tmpl.self_link}"
}
}
```

### `update_strategy` has been replaced by `update_policy`

To allow much greater control over the updates happening to instance groups
`update_strategy` has been replaced by `update_policy`. The previous
functionality to determine if instance should be replaced or restarted can be
achieved using `update_policy.minimal_action`. For more details see the
[official guide](https://cloud.google.com/compute/docs/instance-groups/rolling-out-updates-to-managed-instance-groups).

## Resource: `google_compute_instance_template`

### At least one of `enable_secure_boot`, `enable_vtpm`, or `enable_integrity_monitoring` is now
Expand Down Expand Up @@ -769,13 +816,6 @@ is now required on `google_compute_region_health_check.ssl_health_check` and `go
In an attempt to avoid allowing empty blocks in config files, at least one of `request`, `response`, `port`, `port_name`,
`proxy_header`, or `port_specification` is now required on the `ssl_health_check` and `tcp_health_check` blocks.

## Resource: `google_compute_region_instance_group_manager`

### `update_strategy` no longer has any effect and is removed

With `rolling_update_policy` removed, `update_strategy` has no effect anymore.
Before updating, remove it from your config.

## Resource: `google_compute_resource_policy`

### Exactly one of `hourly_schedule`, `daily_schedule` or `weekly_schedule` on
Expand Down
12 changes: 1 addition & 11 deletions third_party/terraform/website/docs/r/compute_instance_group_manager.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,9 @@ The following arguments are supported:
appending a hyphen and a random four-character string to the base instance
name.

* `instance_template` - (Deprecated) The
full URL to an instance template from which all new instances
will be created. This field is replaced by `version.instance_template`. You must
specify at least one `version` block with an `instance_template`.

* `version` - (Optional) Application versions managed by this instance group. Each
* `version` - (Required) Application versions managed by this instance group. Each
version deals with a specific instance template, allowing canary release scenarios.
Structure is documented below.
Until `instance_template` is removed this field will be Optional to allow for a
graceful upgrade. In the Beta provider and as of 3.0.0 it will be Required.

* `name` - (Required) The name of the instance group manager. Must be 1-63
characters long and comply with
Expand All @@ -124,9 +117,6 @@ The following arguments are supported:
* `project` - (Optional) The ID of the project in which the resource belongs. If it
is not provided, the provider project is used.

* `update_strategy` - (Deprecated) This field has been deprecated, use `update_policy`
instead.

* `target_size` - (Optional) The target number of running instances for this managed
instance group. This value should always be explicitly set unless this resource is attached to
an autoscaler, in which case it should never be set. Defaults to `0`.
Expand Down
9 changes: 1 addition & 8 deletions ...ty/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,9 @@ The following arguments are supported:
appending a hyphen and a random four-character string to the base instance
name.

* `instance_template` - (Deprecated) The
full URL to an instance template from which all new instances
will be created. This field is replaced by `version.instance_template`. You must
specify at least one `version` block with an `instance_template`.

* `version` - (Optional) Application versions managed by this instance group. Each
* `version` - (Required) Application versions managed by this instance group. Each
version deals with a specific instance template, allowing canary release scenarios.
Structure is documented below.
Until `instance_template` is removed this field will be Optional to allow for a
graceful upgrade. In the Beta provider and as of 3.0.0 it will be Required.

* `name` - (Required) The name of the instance group manager. Must be 1-63
characters long and comply with
Expand Down