Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix improve provider credentials docs. Fixes hashicorp#21471 #13111

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

dolfandringa
Copy link
Contributor

@dolfandringa dolfandringa commented Feb 18, 2025

Adds more docs on the credentials argument to the google provider.

Related Issues

hashicorp/terraform-provider-google#21471

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Added documentation on how to use the `credentials` parameter for the google terraform provider

Copy link

google-cla bot commented Feb 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez February 18, 2025 22:43
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 18, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 12 insertions(+), 2 deletions(-))

@rileykarson
Copy link
Member

rileykarson commented Feb 20, 2025

@ScottSuarez I don't think this change is correct. The file() function returns the contents of a path, and is equivalent to supplying the contents directly. We also support supplying a path directly, and open the field directly from the provider. Can you revert and reopen the issue? Thanks!

@ScottSuarez
Copy link
Contributor

@ScottSuarez I don't think this change is correct. The file() function returns the contents of a path, and is equivalent to supplying the contents directly. We also support supplying a path directly, and open the field directly from the provider. Can you revert and reopen the issue? Thanks!

You got it ! Thanks for double checking this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants