Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource for creating Whistle Mapping, Reconciliation and Backfill Pipeline Jobs for Healthcare Data Engine #11812

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

ashwinsshetty
Copy link
Contributor

@ashwinsshetty ashwinsshetty commented Sep 25, 2024

Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine

Link: https://cloud.google.com/healthcare-api/healthcare-data-engine/docs/reference/rest/v1/projects.locations.datasets.pipelineJobs/create

Fixes hashicorp/terraform-provider-google#19412

`google_healthcare_pipeline_job`

@github-actions github-actions bot requested a review from melinath September 25, 2024 15:39
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 insertions(+))
Open in Cloud Shell: Diff ( 3 files changed, 27 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 41
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • healthcare

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample[Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample[Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashwinsshetty
The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request has become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

@ashwinsshetty
Copy link
Contributor Author

updated documentation

Thanks for the note @c2thorn

Please go ahead with your process to force push the changes to my fork.

Please do let me know if any additional action would be required from my side on this.

cc @melinath @trodge

@github-actions github-actions bot requested a review from c2thorn September 26, 2024 05:24
Additional Permissions added to HC SA
Adding test cases for few missing fields
removing spanner related fields
lint yaml corections
pipeline job changes for whistle mapping
pipeline job changes 10
pipeline job changes 9
pipeline job changes 8
pipeline job changes 7
pipeline job changes 6
pipeline job changes 5
pipeline job changes 4
pipeline job changes3
Pipeline Job changes2
Pipeline Job changes1
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 insertions(+))
Open in Cloud Shell: Diff ( 3 files changed, 27 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 insertions(+))
Open in Cloud Shell: Diff ( 3 files changed, 27 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 42
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • healthcare

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 42
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • healthcare

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2078 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 insertions(+))
Open in Cloud Shell: Diff ( 3 files changed, 27 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 44
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@c2thorn
Copy link
Member

c2thorn commented Sep 27, 2024

Got it converted, should be good to resume

@ashwinsshetty
Copy link
Contributor Author

Got it converted, should be good to resume

Thanks @c2thorn!

@melinath Please let me know if anything else would be required to get this merged.

Copy link

@melinath @c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwinsshetty how is this different than #11677? It looks like the same resource is being added.

@melinath
Copy link
Member

oh, that was reverted.

@melinath melinath requested review from trodge and removed request for c2thorn October 1, 2024 15:12
@melinath
Copy link
Member

melinath commented Oct 1, 2024

Moving review to trodge as reviewer of the previous iteration.

@trodge trodge merged commit 7abd8ad into GoogleCloudPlatform:main Oct 1, 2024
12 checks passed
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812)

Co-authored-by: Cameron Thornton <camthornton@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine
5 participants