-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource for creating Whistle Mapping, Reconciliation and Backfill Pipeline Jobs for Healthcare Data Engine #11812
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 44 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashwinsshetty
The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)
This open pull request has become incompatible due to most YAML and .erb files converting to Go-compatible files.
Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.
In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.
You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.
We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!
Additional Permissions added to HC SA Adding test cases for few missing fields removing spanner related fields lint yaml corections pipeline job changes for whistle mapping pipeline job changes 10 pipeline job changes 9 pipeline job changes 8 pipeline job changes 7 pipeline job changes 6 pipeline job changes 5 pipeline job changes 4 pipeline job changes3 Pipeline Job changes2 Pipeline Job changes1
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 44 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 44 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 44 Click here to see the affected service packages
View the build log |
Got it converted, should be good to resume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashwinsshetty how is this different than #11677? It looks like the same resource is being added.
oh, that was reverted. |
Moving review to trodge as reviewer of the previous iteration. |
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <camthornton@google.com>
Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine
Link: https://cloud.google.com/healthcare-api/healthcare-data-engine/docs/reference/rest/v1/projects.locations.datasets.pipelineJobs/create
Fixes hashicorp/terraform-provider-google#19412