Final* go rewrite services

[NickElliot]

All remaining services

a good number of hand written files needed minor syncing for services that were updated since the handwritten templates were batch converted. but since a lot of handwritten files have been minorly updated for whitespace, odds are we will need to re-sync them by hand for ones that need to be re-updated

I think the large yaml regeneration is the next step here, but hopefully would not result in any "new" diffs from the minor ones we accepted as inevitable

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 391 insertions(+), 391 deletions(-))
google-beta provider: Diff ( 14 files changed, 451 insertions(+), 452 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 80 insertions(+), 80 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 556 insertions(+), 556 deletions(-))
google-beta provider: Diff ( 17 files changed, 618 insertions(+), 619 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 125 insertions(+), 125 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp
• parallelstore

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccNetappActiveDirectory_netappActiveDirectoryFullExample
• TestAccNetappBackupPolicy_netappBackupPolicyFullExample
• TestAccNetappBackup_netappBackupExample
• TestAccNetappStoragePool_storagePoolCreateExample
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 556 insertions(+), 556 deletions(-))
google-beta provider: Diff ( 17 files changed, 618 insertions(+), 619 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 125 insertions(+), 125 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp
• parallelstore

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccNetappActiveDirectory_netappActiveDirectoryFullExample
• TestAccNetappBackupPolicy_netappBackupPolicyFullExample
• TestAccNetappBackup_netappBackupExample
• TestAccNetappStoragePool_storagePoolCreateExample
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 29 files changed, 615 insertions(+), 615 deletions(-))
google-beta provider: Diff ( 30 files changed, 687 insertions(+), 688 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 126 insertions(+), 126 deletions(-))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 8
Skipped tests: 0
Affected tests: 12

Click here to see the affected service packages

• parallelstore
• netapp

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappActiveDirectory_activeDirectory_FullUpdate
• TestAccNetappActiveDirectory_netappActiveDirectoryFullExample
• TestAccNetappBackupPolicy_NetappBackupPolicyFullExample_update
• TestAccNetappBackupPolicy_netappBackupPolicyFullExample
• TestAccNetappBackupVault_NetappBackupVaultExample_update
• TestAccNetappBackup_NetappBackupFull_update
• TestAccNetappBackup_netappBackupExample
• TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update
• TestAccNetappStoragePool_storagePoolCreateExample
• TestAccNetappStoragePool_storagePoolCreateExample_update
• TestAccNetappVolumeReplication_NetappVolumeReplicationCreateExample_update
• TestAccNetappVolume_NetappVolumeBasicExample_update

Get to know how VCR tests work

[c2thorn]

LGTM assuming tests pass

[NickElliot]

While waiting on the tests I wanted to call attention to a specific change: https://github.com/GoogleCloudPlatform/magic-modules/pull/11593/files#diff-d4257ecf68b40cde4cd0e6f0b557a06b872641c57dbda2bcc459c1a6691013ff

This satisfied the new issue I ran into from your original change (bd00206#diff-d4257ecf68b40cde4cd0e6f0b557a06b872641c57dbda2bcc459c1a6691013ff) that was a deviation from the original Ruby logic, but because your version caused a change in a resource I went over, it potentially also introduced diffs in other resources. Hopefully the way I altered it pre-emptively fixed those too, but something to keep in mind if we see new diffs after syncing it all

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappActiveDirectory_netappActiveDirectoryFullExample[Debug log]
TestAccNetappBackupPolicy_NetappBackupPolicyFullExample_update[Debug log]
TestAccNetappBackupPolicy_netappBackupPolicyFullExample[Debug log]
TestAccNetappBackupVault_NetappBackupVaultExample_update[Debug log]
TestAccNetappBackup_netappBackupExample[Debug log]
TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update[Debug log]
TestAccNetappStoragePool_storagePoolCreateExample[Debug log]
TestAccNetappStoragePool_storagePoolCreateExample_update[Debug log]
TestAccNetappVolumeReplication_NetappVolumeReplicationCreateExample_update[Debug log]
TestAccNetappVolume_NetappVolumeBasicExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappActiveDirectory_activeDirectory_FullUpdate[Error message] [Debug log]
TestAccNetappBackup_NetappBackupFull_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[NickElliot]

test failure looks to be a problem of all the netapp tests being ran together

[c2thorn]

This should be good to go