Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to regular from stable channel - #67

Open
jlewi opened this issue Jun 30, 2020 · 6 comments
Open

Switch to regular from stable channel - #67

jlewi opened this issue Jun 30, 2020 · 6 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 30, 2020

We should switch to using the regular channel over the stable channel by default.

Regular is on 1.16: https://cloud.google.com/kubernetes-engine/docs/release-notes-regular
Stable is still on 1.14 https://cloud.google.com/kubernetes-engine/docs/release-notes-stable

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.89
platform/gcp 0.95

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

jlewi pushed a commit to jlewi/manifests that referenced this issue Jul 8, 2020
* Stable is still on 1.14 which is getting to be quite old.
  Tekton for example requires 1.15 at least.

Related to: GoogleCloudPlatform/kubeflow-distribution#67
k8s-ci-robot pushed a commit to kubeflow/manifests that referenced this issue Jul 8, 2020
* Stable is still on 1.14 which is getting to be quite old.
  Tekton for example requires 1.15 at least.

Related to: GoogleCloudPlatform/kubeflow-distribution#67
@jlewi
Copy link
Contributor Author

jlewi commented Jul 10, 2020

This is on master but not the 1.1 branch.
Things look pretty good on master:
https://kf-vbp-0710-7fc.endpoints.kubeflow-ci-deployment.cloud.goog/
Looks healthy.

Tests are failing because the tests need to be updated to use v1 APIs

jlewi pushed a commit to jlewi/testing that referenced this issue Jul 10, 2020
Tests should be using the V1 API for deployments.

related to: GoogleCloudPlatform/kubeflow-distribution#67
k8s-ci-robot pushed a commit to kubeflow/testing that referenced this issue Jul 10, 2020
* Update tests to work with Kubernetes 1.16

Tests should be using the V1 API for deployments.

related to: GoogleCloudPlatform/kubeflow-distribution#67

* * Update statefulsets to v1 api
@jlewi
Copy link
Contributor Author

jlewi commented Jul 13, 2020

Deployment on master is failing.

error: unable to recognize ".build/kubeflow-apps/apps_v1beta1_deployment_kubeflow-pipelines-profile-controller.yaml": no matches for kind "Deployment" in version "apps/v1beta1"
Makefile:195: recipe for target 'apply-kubeflow' failed

Looks like it should be apps/v1

@jlewi
Copy link
Contributor Author

jlewi commented Jul 13, 2020

This should be fixed by kubeflow/manifests#1374 which changed it from apps/v1beta1 to apps/v1

@jlewi
Copy link
Contributor Author

jlewi commented Jul 14, 2020

Tests are still failing on master.

 return self.api_client.call_api('/apis/extensions/v1beta1/namespaces/{namespace}/deployments/{name}', 'GET',
                                        path_params,
                                        query_params,
                                        header_params,
                                        body=body_params,
                                        post_params=form_params,
                                        files=local_var_files,
                                        response_type='ExtensionsV1beta1Deployment',
                                        auth_settings=auth_settings,
                                        async_req=params.get('async_req'),
                                        _return_http_data_only=params.get('_return_http_data_only'),
                                        _preload_content=params.get('_preload_content', True),
                                        _request_timeout=params.get('_request_timeout'),
                                        collection_formats=collection_formats)

This is coming from:
/srcCache/kubeflow/testing/py/kubeflow/testing/util.py:437:

@jlewi
Copy link
Contributor Author

jlewi commented Jul 14, 2020

This was fixed in kubeflow/testing#727 but the test image wasn't rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant