-
Notifications
You must be signed in to change notification settings - Fork 67
Updating latest depencies #150
Updating latest depencies #150
Conversation
Verified that @madhusudancs Will be great if you can take a look since I am not sure if @csbell and @G-Harmon will get to. |
efe9509
to
472c593
Compare
@@ -59,7 +59,7 @@ func (b *BackendServiceSyncer) EnsureBackendService(lbName string, ports []ingre | |||
var err error | |||
ensuredBackendServices := BackendServicesMap{} | |||
for _, p := range ports { | |||
be, beErr := b.ensureBackendService(lbName, p, hcMap[p.Port], npMap[p.Port], igLinks, forceUpdate) | |||
be, beErr := b.ensureBackendService(lbName, p, hcMap[p.NodePort], npMap[p.NodePort], igLinks, forceUpdate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated to latest dependencies. Is it intentional? The linked triggers don't clarify this either.
Could you please explain this change in the PR description or link to the relevant trigger? Same question for all the Port
-> NodePort
changes below. I think I am missing context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more context. This is because the struct that we are using from ingress-gce renamed Port to NodePort: kubernetes/ingress-gce#128
To add more context, the second commit has following changes that were required to fix the build:
These are all due to changes to ingress-gce code that we are using. |
Thanks for the clarification. It would be great if you can copy that comment to your original PR description and/or the second commit so others who might have to bisect the commits get better visibility. |
/lgtm |
Sure updated the PR description as well. Thanks! |
First commit auto generated by running
glide update --strip-vendor
.Had to clear cache as per @G-Harmon's suggestion: Masterminds/glide#592 (comment)
Also removed the kubernetes pin that was added in #93
Second commit is to fix the build using latest dependencies (renames and code moves).
It has following changes that were required to fix the build:
Trigger for getting latest change: kubernetes/ingress-gce#169, kubernetes/ingress-gce#165.
cc @G-Harmon @csbell @madhusudancs