Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compositions: Fix manual install version #2605

Merged

Conversation

barney-s
Copy link
Collaborator

@barney-s barney-s commented Sep 1, 2024

Change description

Manual install version had a v prefix which our release images does not have.

@barney-s barney-s requested a review from xiaoweim September 1, 2024 21:55
@barney-s
Copy link
Collaborator Author

barney-s commented Sep 1, 2024

/assign @cheftako

@cheftako
Copy link
Collaborator

cheftako commented Sep 1, 2024

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 1, 2024
@cheftako
Copy link
Collaborator

cheftako commented Sep 1, 2024

Looks like we have a lint issue we need to look into

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4d839f2 into GoogleCloudPlatform:master Sep 1, 2024
10 of 11 checks passed
@barney-s barney-s deleted the fix-manual-install branch September 2, 2024 06:44
@yuwenma yuwenma added this to the 1.122 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants