Add 'IAP_VERIFY_AUDIENCE' option to en/disable audience check #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this for `IAP_BACKEND_SERVICE_ID` will skip verification of the audience, allowing us to avoid the circular dependency from #324, although it will still validate that the JWT audience contains the correct project. This option should be used by clients who have already verified that the caller can only recieve traffic already validated by IAP and that the project does not have any other backend services with less secure IAP settings.
aebrahim
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration option
IAP_VERIFY_AUDIENCE:true, meaning that the audience of IAP assertions is verified.false, the audience of IAP assertions is not verified and the optionIAP_BACKEND_SERVICE_IDis ignored.NB. The assertion's signature is always verified, regardless of
IAP_VERIFY_AUDIENCE.