Fix broken tests (#53)

* Change testIamPermission test to not rely on undocumented behavior * Add missing mock configuration for IAP header tests
GoogleCloudPlatform · Mar 14, 2023 · 96fca59 · 96fca59
1 parent a0c61ed
commit 96fca59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...rc/test/java/com/google/solutions/jitaccess/core/adapters/TestResourceManagerAdapter.java b/...rc/test/java/com/google/solutions/jitaccess/core/adapters/TestResourceManagerAdapter.java
@@ -387,10 +387,9 @@ public void whenAuthorized_ThenTestIamPermissionsSucceeds() throws Exception {
 
     var heldPermissions = adapter.testIamPermissions(
       IntegrationTestEnvironment.PROJECT_ID,
-      List.of(
-        "resourcemanager.projects.get",
-        "resourcemanager.projects.xxx"));
+      List.of("resourcemanager.projects.get"));
 
     assertNotNull(heldPermissions);
+    assertEquals(1, heldPermissions.size());
   }
 }
diff --git a/sources/src/test/java/com/google/solutions/jitaccess/web/TestIapRequestFilter.java b/sources/src/test/java/com/google/solutions/jitaccess/web/TestIapRequestFilter.java
@@ -39,6 +39,7 @@ public void whenHeaderMissing_ThenFilterThrowsForbiddenException() {
     RuntimeEnvironment environment = Mockito.mock(RuntimeEnvironment.class);
     when(environment.getProjectId()).thenReturn("123");
     when(environment.getProjectNumber()).thenReturn("123");
+    when(environment.isRunningOnAppEngine()).thenReturn(true);
     when(environment.isDebugModeEnabled()).thenReturn(false);
 
     IapRequestFilter filter = new IapRequestFilter();
@@ -56,6 +57,7 @@ public void whenHeaderContainsMalformedJwt_ThenFilterThrowsForbiddenException()
     RuntimeEnvironment environment = Mockito.mock(RuntimeEnvironment.class);
     when(environment.getProjectId()).thenReturn("123");
     when(environment.getProjectNumber()).thenReturn("123");
+    when(environment.isRunningOnAppEngine()).thenReturn(true);
     when(environment.isDebugModeEnabled()).thenReturn(false);
 
     IapRequestFilter filter = new IapRequestFilter();
@@ -73,6 +75,7 @@ public void whenHeaderContainsInvalidJwt_ThenFilterThrowsForbiddenException() {
     RuntimeEnvironment environment = Mockito.mock(RuntimeEnvironment.class);
     when(environment.getProjectId()).thenReturn("123");
     when(environment.getProjectNumber()).thenReturn("123");
+    when(environment.isRunningOnAppEngine()).thenReturn(true);
     when(environment.isDebugModeEnabled()).thenReturn(false);
 
     IapRequestFilter filter = new IapRequestFilter();