Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checkstyle configs to its own resources package. #45

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 10, 2016

The checkstyle config can read from the resources of a package. It can't
read from the resources of the package it is included in, though (plus
you can't use a jar as a parent, anyway).

See: http://stackoverflow.com/a/19690484/101923

@lesv This should prevent us from having to duplicate these resources in all our repos.

Fixes #41

@tswast
Copy link
Contributor Author

tswast commented Nov 10, 2016

Travis failure was because I forgot to mvn deploy the SNAPSHOT version of the checkstyle-configuration jar.

The checkstyle config can read from the resources of a package. It can't
read from the resources of the package it is included in, though (plus
you can't use a jar as a parent, anyway).

See: http://stackoverflow.com/a/19690484/101923
@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #45 into master will not change coverage

@@           master   #45   diff @@
===================================
  Files           1     1          
  Lines           5     5          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits            5     5          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 264a358...1e1f9be

@tswast tswast merged commit 8605121 into master Nov 11, 2016
@tswast
Copy link
Contributor Author

tswast commented Nov 11, 2016

Force merging so I can make a release with this. I've tested with the snapshot version locally on java-docs-samples.

@lesv PTAL

@tswast tswast deleted the tswast-resources branch November 11, 2016 00:10
@lesv
Copy link
Contributor

lesv commented Nov 11, 2016

Cool - I was about to ask you about this as I wanted to put it in the Bookshelf.

@lesv
Copy link
Contributor

lesv commented Nov 11, 2016

The only comment I have is that the snapshot should be after the release, and you should have a protocol for release.

I.E.:

  1. Commit all changes, test.
  2. update& commit the version for release from x.x.x-SNAPSHOT to x.x.x
  3. push to maven central
  4. update & commit the version for release to x.x.y-SNAPSHOT

@tswast
Copy link
Contributor Author

tswast commented Nov 11, 2016

Yes, that protocol is basically what the Maven releases plugin does.
http://maven.apache.org/maven-release/maven-release-plugin/index.html

I'll be sure to document the steps when I make the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants