Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automl: explictly update timeoutes due to default library changes #2719

Merged
merged 14 commits into from
Apr 24, 2020

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Apr 21, 2020

Fixes PR: #2704

It's a good idea to open an issue first for discussion.

  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)

@nnegrey nnegrey requested a review from a team April 21, 2020 22:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@nnegrey nnegrey added the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

AutoML provides no guarantee on how long this could take and normally would send an email followup. Though normally, I see this finish in under 10 mins. Trying to pin down if TASK CANCELLED is actually related to a timeout or not.
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@nnegrey nnegrey removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2020
@nnegrey nnegrey merged commit 7550386 into master Apr 24, 2020
@nnegrey nnegrey deleted the fix-automl-test branch April 24, 2020 22:31
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…anges (#2719)

* automl: explictly update timeoutes due to library changes in the defaults

* Update ImportDataset.java

* try bumping timeout

AutoML provides no guarantee on how long this could take and normally would send an email followup. Though normally, I see this finish in under 10 mins. Trying to pin down if TASK CANCELLED is actually related to a timeout or not.

* update timeouts for all import methods

* undo changes to TablesImport, add catch for Cancellation Exception

* update to correct CancelledException

* wrong cancellation again

* run tests

* log to error

* test

* reset changes that printed error

* set retry settings

* add timeout check to beta code
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…anges (#2719)

* automl: explictly update timeoutes due to library changes in the defaults

* Update ImportDataset.java

* try bumping timeout

AutoML provides no guarantee on how long this could take and normally would send an email followup. Though normally, I see this finish in under 10 mins. Trying to pin down if TASK CANCELLED is actually related to a timeout or not.

* update timeouts for all import methods

* undo changes to TablesImport, add catch for Cancellation Exception

* update to correct CancelledException

* wrong cancellation again

* run tests

* log to error

* test

* reset changes that printed error

* set retry settings

* add timeout check to beta code
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…anges (#2719)

* automl: explictly update timeoutes due to library changes in the defaults

* Update ImportDataset.java

* try bumping timeout

AutoML provides no guarantee on how long this could take and normally would send an email followup. Though normally, I see this finish in under 10 mins. Trying to pin down if TASK CANCELLED is actually related to a timeout or not.

* update timeouts for all import methods

* undo changes to TablesImport, add catch for Cancellation Exception

* update to correct CancelledException

* wrong cancellation again

* run tests

* log to error

* test

* reset changes that printed error

* set retry settings

* add timeout check to beta code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants