Propose new sample format. #1232

kurtisvg · 2018-10-15T16:56:03Z

Updated InspectString and InspectFile snippets to the newly proposed format.

dlp/src/main/java/dlp/snippets/InspectFile.java

dlp/src/main/java/dlp.snippets/InspectFile.java

lesv · 2018-10-22T17:15:00Z

dlp/src/main/java/dlp.snippets/InspectFile.java

+          .build();
+
+      // Run request and parse response
+      InspectContentResponse response = dlp.inspectContent(request);


How long does this take? Should I make it async? Do it in it's own thread, or in a separate microservice? How does this code guide my architecture choices?

The snippets with longer running operations use PubSub actions for longer running jobs. Do you think that with a comparison between different snippets there is enough suggestions for architecture choices? If not, do you have suggestions on how to better convey it?

I'd be inclined to mention it in the preamble (class or method comments).

lesv

I like this, I just think there should be some additional context provided to our users. Explaining what situations you might call this vs. some other possible situations that might require something bigger. (ie. architecture hints)

dlp/src/test/java/dlp/snippets/InspectTests.java

tswast

I like the new structure. Much clearer without a CLI.

dlp/src/main/java/com/example/dlp/Inspect.java

dlp/src/main/java/dlp/snippets/InspectFile.java

tswast

LGTM

dlp/src/main/java/dlp/snippets/InspectFile.java

dlp/src/main/java/com/example/dlp/Inspect.java

dlp/src/test/java/dlp/snippets/InspectTests.java

kurtisvg · 2019-02-15T21:38:20Z

@dzlier-gcp Ready for another review.

kurtisvg · 2019-02-24T21:39:34Z

@dzlier-gcp ping

dzlier-gcp · 2019-02-25T21:08:55Z

dlp/src/test/java/dlp/snippets/RedactTests.java

@@ -16,6 +16,7 @@

 package dlp.snippets;

+// [START dlp_redact_image]


Is this intentional? If it is there's no end tag.

It was not intentional. Fixed.

…eCloudPlatform#1232)" This reverts commit 6bb16d1.

…1.1 (#1232) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).

* Update DLP snippet with proposal for new sample format. * Fix InspectFile region tag. * Fixed package structure and InspectString test. * Reword comments. * Fix unintentional toString. * Seperate API call from response processing. * Seperate ByteType into two different samples. * Remove previous tests. * Updated Redact sample to new format. * Clean up comments. * Bump license year. * Fixed redact test. * Remove old redact snippet and move region tags. * Remove region tag.

kurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2018

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2018

kurtisvg force-pushed the example-sample branch 2 times, most recently from 8ba8b0b to f53ac56 Compare October 15, 2018 17:12

kurtisvg mentioned this pull request Oct 16, 2018

KMS changes #1218

Merged

nnegrey reviewed Oct 19, 2018

View reviewed changes

dlp/src/main/java/dlp/snippets/InspectFile.java Outdated Show resolved Hide resolved

kurtisvg force-pushed the example-sample branch from 6128895 to 7dbeb88 Compare October 19, 2018 23:45

lesv reviewed Oct 22, 2018

View reviewed changes

dlp/src/main/java/dlp.snippets/InspectFile.java Outdated Show resolved Hide resolved

lesv reviewed Oct 22, 2018

View reviewed changes

dlp/src/main/java/dlp.snippets/InspectFile.java Outdated Show resolved Hide resolved

lesv reviewed Oct 22, 2018

View reviewed changes

dzlier-gcp reviewed Oct 22, 2018

View reviewed changes

dlp/src/test/java/dlp/snippets/InspectTests.java Show resolved Hide resolved

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 22, 2018

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 22, 2018

tswast reviewed Oct 23, 2018

View reviewed changes

dlp/src/main/java/com/example/dlp/Inspect.java Show resolved Hide resolved

dlp/src/main/java/dlp/snippets/InspectFile.java Outdated Show resolved Hide resolved

tswast reviewed Oct 24, 2018

View reviewed changes

dlp/src/main/java/dlp/snippets/InspectFile.java Outdated Show resolved Hide resolved

kurtisvg force-pushed the example-sample branch from 32205e0 to f233ede Compare November 7, 2018 18:12

nnegrey mentioned this pull request Dec 12, 2018

Infinite Stream recognition #1297

Merged

kurtisvg mentioned this pull request Feb 8, 2019

Endpoints Auth Between Services #1330

Merged

dzlier-gcp reviewed Feb 15, 2019

View reviewed changes

dlp/src/main/java/com/example/dlp/Inspect.java Show resolved Hide resolved

kurtisvg force-pushed the example-sample branch from f233ede to 52e25a4 Compare February 15, 2019 16:22

kurtisvg requested a review from a team February 15, 2019 16:22

dzlier-gcp reviewed Feb 15, 2019

View reviewed changes

dlp/src/test/java/dlp/snippets/InspectTests.java Outdated Show resolved Hide resolved

kurtisvg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 25, 2019

kurtisvg changed the title ~~[DO NOT MERGE] Propose new sample format.~~ Propose new sample format. Feb 25, 2019

dzlier-gcp reviewed Feb 25, 2019

View reviewed changes

kurtisvg force-pushed the example-sample branch from b716e47 to c460fed Compare February 25, 2019 21:51

Update DLP snippet with proposal for new sample format.

a9b739c

kurtisvg and others added 13 commits February 25, 2019 13:52

Fix InspectFile region tag.

e0b886d

Fixed package structure and InspectString test.

494f4f9

Reword comments.

9bb5399

Fix unintentional toString.

721bf9f

Seperate API call from response processing.

1a3dcd8

Seperate ByteType into two different samples.

7f8c860

Remove previous tests.

25626cf

Updated Redact sample to new format.

a045ec4

Clean up comments.

d7ac740

Bump license year.

e0edee3

Fixed redact test.

6f1b076

Remove old redact snippet and move region tags.

e74f484

Remove region tag.

e238683

kurtisvg force-pushed the example-sample branch from c460fed to e238683 Compare February 25, 2019 21:52

dzlier-gcp approved these changes Feb 25, 2019

View reviewed changes

kurtisvg merged commit 6bb16d1 into master Feb 25, 2019

kurtisvg deleted the example-sample branch February 25, 2019 22:27

pheonixblade9 pushed a commit to pheonixblade9/java-docs-samples that referenced this pull request Dec 13, 2019

Revert "Update DLP snippet as canonical for new sample format. (Googl…

bdc248d

…eCloudPlatform#1232)" This reverts commit 6bb16d1.

pheonixblade9 pushed a commit to pheonixblade9/java-docs-samples that referenced this pull request Dec 13, 2019

Revert "Update DLP snippet as canonical for new sample format. (Googl…

c20098b

…eCloudPlatform#1232)" This reverts commit 6bb16d1.

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propose new sample format. #1232

Propose new sample format. #1232

kurtisvg commented Oct 15, 2018

lesv Oct 22, 2018

kurtisvg Oct 22, 2018

lesv Oct 22, 2018

lesv left a comment

tswast left a comment

tswast left a comment

kurtisvg commented Feb 15, 2019

kurtisvg commented Feb 24, 2019

dzlier-gcp Feb 25, 2019

kurtisvg Feb 25, 2019

		@@ -16,6 +16,7 @@

		package dlp.snippets;

		// [START dlp_redact_image]

Propose new sample format. #1232

Propose new sample format. #1232

Conversation

kurtisvg commented Oct 15, 2018

lesv Oct 22, 2018

Choose a reason for hiding this comment

kurtisvg Oct 22, 2018

Choose a reason for hiding this comment

lesv Oct 22, 2018

Choose a reason for hiding this comment

lesv left a comment

Choose a reason for hiding this comment

tswast left a comment

Choose a reason for hiding this comment

tswast left a comment

Choose a reason for hiding this comment

kurtisvg commented Feb 15, 2019

kurtisvg commented Feb 24, 2019

dzlier-gcp Feb 25, 2019

Choose a reason for hiding this comment

kurtisvg Feb 25, 2019

Choose a reason for hiding this comment