Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: add samples for dead letter topics #1279

Merged
merged 9 commits into from
Mar 25, 2020
Merged

pubsub: add samples for dead letter topics #1279

merged 9 commits into from
Mar 25, 2020

Conversation

hongalex
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2020
@hongalex hongalex added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2020
@hongalex
Copy link
Contributor Author

Seems like CI is failing on tests unrelated to pubsub (jobs API)

anguillanneuf
anguillanneuf requested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a test for pullMsgsDeadLetterDeliveryAttempt when dead lettering is triggered vs. not triggered.

Have you considered triggering dead lettering on a push subscription using bad credentials?

@hongalex hongalex requested a review from anguillanneuf March 17, 2020 19:07
anguillanneuf
anguillanneuf requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test for delivery attempt! I added a few more suggestions.

pubsub/subscriptions/pull_dead_letter_delivery_attempts.go Outdated Show resolved Hide resolved
pubsub/subscriptions/create_dead_letter.go Outdated Show resolved Hide resolved
pubsub/subscriptions/pull_dead_letter_delivery_attempts.go Outdated Show resolved Hide resolved
pubsub/subscriptions/pull_dead_letter_delivery_attempts.go Outdated Show resolved Hide resolved
pubsub/subscriptions/subscription_test.go Show resolved Hide resolved
tbpg
tbpg requested changes Mar 19, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pubsub/subscriptions/create_dead_letter.go Outdated Show resolved Hide resolved
pubsub/subscriptions/create_dead_letter.go Outdated Show resolved Hide resolved
pubsub/subscriptions/create_dead_letter.go Outdated Show resolved Hide resolved
pubsub/subscriptions/pull_dead_letter_delivery_attempts.go Outdated Show resolved Hide resolved
pubsub/subscriptions/create_dead_letter.go Outdated Show resolved Hide resolved
pubsub/subscriptions/subscription_test.go Show resolved Hide resolved
pubsub/subscriptions/subscription_test.go Outdated Show resolved Hide resolved
pubsub/subscriptions/subscription_test.go Show resolved Hide resolved
@hongalex hongalex requested review from anguillanneuf and tbpg March 24, 2020 02:24
tbpg
tbpg requested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small comment then LGTM.

go.mod Outdated
@@ -1,19 +1,19 @@
module github.com/GoogleCloudPlatform/golang-samples

go 1.11
go 1.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep as 1.11. This signifies the Go version compatibility, which we need to keep at 1.11, the oldest supported GAE/GCF version.

anguillanneuf
anguillanneuf approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see the library tests cover a wider range of scenarios! LGTM.

@tbpg tbpg merged commit 92eae2e into master Mar 25, 2020
@tbpg tbpg deleted the pubsub-dlq-samples branch March 25, 2020 14:50
This was referenced Jun 1, 2020
Closed
Closed
@anguillanneuf anguillanneuf mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@tbpg tbpg tbpg approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hongalex @anguillanneuf @tbpg @googlebot @kokoro-team