Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add ConnectionName to ConnectionInfo class #1212

Merged
merged 3 commits into from
Dec 9, 2024
Merged

refactor: add ConnectionName to ConnectionInfo class #1212

merged 3 commits into from
Dec 9, 2024
+32 −48

Conversation

jackwotherspoon
Copy link
Collaborator

Adding ConnectionName to ConnectionInfo class to more closely match Go implementation.

Benefits:

  • Cleaner interface, passing connection name around instead of individual args (project, region, instance)
  • Consistent debug logs (give access to ConnectionName throughout)
  • Allows us to tell if ConnectionInfo is using DNS (if ConnectionName.domain_name is set)

This will unblock DNS polling as we must know at the ConnectionInfo level if it is
configured via DNS domain name or not.

Related to #1169

@jackwotherspoon jackwotherspoon self-assigned this Dec 7, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner December 7, 2024 02:37
@jackwotherspoon
Copy link
Collaborator Author

Lint will pass once we merge #1211 first

@jackwotherspoon jackwotherspoon merged commit 7231c57 into main Dec 9, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the dns-polling2 branch December 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hessjcg hessjcg hessjcg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @hessjcg