Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.10.0 binaries are all ELF 64-bit LSB executable, x86-64 #2153

Closed
Fake51 opened this issue Mar 20, 2024 · 3 comments
Closed

Version 2.10.0 binaries are all ELF 64-bit LSB executable, x86-64 #2153

Fake51 opened this issue Mar 20, 2024 · 3 comments
Assignees
@enocom
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Fake51
Copy link

Fake51 commented Mar 20, 2024

Bug Description

The recent change to config handling seems to have broken your CI/CD. The binaries for ARM, and possibly for Mac/Darwin as well, are broken - they're in ELF format, i.e. generated for AMD64 instead.

Example code (or command)

// paste your code or command here

Stacktrace

No response

Steps to reproduce?

 wget -O yada https://storage.googleapis.com/cloud-sql-connectors/cloud-sql-proxy/v2.10.0/cloud-sql-proxy.darwin.arm64
 --2024-03-20 11:48:36--  https://storage.googleapis.com/cloud-sql-connectors/cloud-sql-proxy/v2.10.0/cloud-sql-proxy.darwin.arm64

 Resolving storage.googleapis.com (storage.googleapis.com)... 142.251.9.207, 142.250.147.207, 2a00:1450:4025:c03::cf, ...
 Connecting to storage.googleapis.com (storage.googleapis.com)|142.251.9.207|:443... connected.
 HTTP request sent, awaiting response... 200 OK
 Length: 33083448 (32M) [application/octet-stream]
 Saving to: ‘yada’

 yada                          100%[===============================================>]  31,55M  24,6MB/s    in 1,3s

 2024-03-20 11:48:38 (24,6 MB/s) - ‘yada’ saved [33083448/33083448]

file yada

	yada: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=-swtzDq540l6P9hjIEgE/Ib0kEm_t7DP3y0cJY_c9/FV2GSRwsD8yKQIYf-hAE/K8Xhhh4LnDfH5GGKOGxc, with debug_info, not stripped

Environment

  1. OS type and version: really doesn't matter, but linux - ubuntu 22.04.4
  2. Cloud SQL Proxy version (./cloud-sql-proxy --version): v2.10.0
  3. Proxy invocation command (for example, ./cloud-sql-proxy --port 5432 INSTANCE_CONNECTION_NAME): any

Additional Details

No response
@Fake51 Fake51 added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Mar 20, 2024
@enocom enocom added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Mar 20, 2024
@enocom
Copy link
Member

enocom commented Mar 20, 2024

Thanks for the report. We'll get this fixed ASAP.

@enocom
Copy link
Member

enocom commented Mar 20, 2024

Looks like all binaries are just the Linux binary: ELF 64-bit LSB executable, x86-64.

@enocom enocom changed the title Version 2.10.0 is broken for arm Version 2.10.0 binaries are all ELF 64-bit LSB executable, x86-64 Mar 20, 2024
enocom added a commit that referenced this issue Mar 20, 2024
@enocom
fix: correct CI/CD build error
511702d 
A recent change in the CI/CD infrastructure caused the last release to
miscompile all binaries as Linux x86-64 with dynamic linking. We have
corrected the error in our infrastructure and are cutting a new release
to signal to downstream consumers that the last version is invalid for
all but Linux x86-64.

Fixes #2153
@enocom enocom mentioned this issue Mar 20, 2024
Merged
@enocom
Copy link
Member

enocom commented Mar 20, 2024

The binaries for v2.10.0 are all fixed now.

We're going to cut a separate patch release just in case the bad binaries have been pulled into automated workflows. It's otherwise identical to v2.10.0.

@enocom enocom closed this as completed Mar 20, 2024
enocom added a commit that referenced this issue Mar 20, 2024
@enocom
fix: correct CI/CD build error (#2155)
3e3b8ed 
A recent change in the CI/CD infrastructure caused the last release to
miscompile all binaries as Linux x86-64 with dynamic linking. We have
corrected the error in our infrastructure and are cutting a new release
to signal to downstream consumers that the last version is invalid for
all but Linux x86-64.

Related to #2153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fake51 @enocom