refactor: clean up connection info cache interface #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove two methods from interface - Move connection count into dialer - Use ConnectionInfo to resolve DB version
jackwotherspoon
requested changes
Apr 15, 2024
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
enocom
added a commit
that referenced
this pull request
May 27, 2024
In #768, we removed an implicit behavior of the Go Connector. If a dial attempt requests a non-existent IP type (e.g., client asks for public IP on a private IP only instance), the Connector would invalidate the cache. But with the cleanup PR, we removed that implicit behavior. In some cases, it might be useful to have this behavior. For example, if a caller starts the Go Connector and tries to connect to a public IP and then later configures public IP, there is no need for a restart. We made that change in the AlloyDB Go Connector mostly because some internal tests depend on that behavior. See GoogleCloudPlatform/alloydb-go-connector#555. Fixes #780
enocom
added a commit
that referenced
this pull request
May 28, 2024
In #768, we removed an implicit behavior of the Go Connector. If a dial attempt requests a non-existent IP type (e.g., client asks for public IP on a private IP only instance), the Connector would invalidate the cache. But with the cleanup PR, we removed that implicit behavior. In some cases, it might be useful to have this behavior. For example, if a caller starts the Go Connector and tries to connect to a public IP and then later configures public IP, there is no need for a restart. We made that change in the AlloyDB Go Connector mostly because some internal tests depend on that behavior. See GoogleCloudPlatform/alloydb-go-connector#555. Fixes #780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shrinks the interface for the connection info cache. A smaller interface makes it easier to provide alternate implementations. Separately, the ConnectionInfo provides a super set of the InstanceEngineVersion data, making InstanceEngineVersion a duplicate method in effect. Also, connection count tracking shouldn't be done at the cache layer and instead should be done at the dialer layer. As a result, this PR removes two methods from the interface for a tighter and clean abstraction.