-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory leak in database/sql integration #162
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Hi @stepan-romankov - Thanks for taking the time to open an issue, identify the cause, and suggest a fix. It's greatly appreciated. Are you able to sign the CLA? We need to have the CLA signed before we can leave feedback on your PR or accept the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a fix for this!
Should already be done... |
Unfortunately, I just ran the CLA check and it's still showing up missing. You can follow the instructions in that link to check your status. |
Looks ok now. |
I implemented all the requested changes. Please review @enocom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things. Otherwise LGTM
@enocom done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Change Description
There is a memory leak in postgres/pgxv4/postgres.go:60
func (p *pgDriver) Open(name string) (driver.Conn, error)
This happens because
stdlib.RegisterConnConfig()
on every connection opening returns new dbURI and stores new instance ofpgx.ConnConfig
to map indexed by dbURIRelevant issues: