Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: use singular name for package #101

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix!: use singular name for package #101

merged 2 commits into from
Feb 9, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Feb 8, 2022 •
edited
Loading

In go, package names are not plural. This is surprising to programmers who came from other languages and are retaining an old habit of pluralizing names. Don’t name a package httputils, but httputil!

See https://rakyll.org/style-packages.

@enocom enocom requested a review from a team February 8, 2022 22:34
kurtisvg
kurtisvg suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed some in "dialer_test"

@enocom enocom requested a review from kurtisvg February 9, 2022 02:15
@enocom enocom merged commit 5e5589d into main Feb 9, 2022
@enocom enocom deleted the singular-package branch February 9, 2022 16:06
This was referenced Feb 9, 2022
Closed
Open
@github-actions github-actions bot mentioned this pull request Mar 1, 2022
Merged
This was referenced Apr 5, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enocom @kurtisvg