Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring the Dial func #56

Closed
enocom opened this issue Nov 11, 2021 · 0 comments · Fixed by #57
Closed

Add support for configuring the Dial func #56

enocom opened this issue Nov 11, 2021 · 0 comments · Fixed by #57
Assignees
@enocom
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Nov 11, 2021

Presently, we default to proxy.Dial. Some clients will need to provide set up their own network path and will want to override this.

https://github.com/kurtisvg/cloud-sql-go-connector/blob/86f37d7a784ae5e73b02e78dfc3e7970efc9f89a/dialer.go#L193
@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 11, 2021
@enocom enocom self-assigned this Nov 11, 2021
enocom added a commit that referenced this issue Nov 15, 2021
@enocom
feat: allow for configuring the Dial func
20bcf5b 
Fixes #56.
@enocom enocom mentioned this issue Nov 15, 2021
Merged
enocom added a commit that referenced this issue Nov 17, 2021
@enocom
feat: allow for configuring the Dial func (#57)
4cb523e 
Fixes #56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow for configuring the Dial func GoogleCloudPlatform/cloud-sql-go-connector
1 participant
@enocom