Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying custom HTTP client #54

Closed
enocom opened this issue Nov 11, 2021 · 0 comments · Fixed by #55
Closed

Add support for specifying custom HTTP client #54

enocom opened this issue Nov 11, 2021 · 0 comments · Fixed by #55
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Nov 11, 2021

Something like this will allow clients to configure the SQL Admin API client as needed.

func WithSQLAdminOption(opt apiopt.ClientOption) DialerOption {
       return func(d *dialerConfig) {
               d.sqladminOpts = append(d.sqladminOpts, opt)
       }
}
@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 11, 2021
@enocom enocom self-assigned this Nov 11, 2021
@enocom enocom changed the title Add support for specifying customer SQL Admin API options Add support for specifying custom HTTP client Nov 11, 2021
enocom added a commit that referenced this issue Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant