Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for GAE Java21 is coming soon #935

Closed
ludoch opened this issue Sep 25, 2023 · 1 comment · Fixed by #936
Closed

Support for GAE Java21 is coming soon #935

ludoch opened this issue Sep 25, 2023 · 1 comment · Fixed by #936
Assignees
@meltsufin
Labels
p2 type: feature request

Comments

@ludoch
Copy link
Collaborator

ludoch commented Sep 25, 2023

GAE will provide java21 runtime support soon.
In order to prepare our release, we need to test end 2 end java21 support.
I see java11/17 hardcoded in src/main/java/com/google/cloud/tools/appengine/operations/AppYamlProjectStaging.java

We need to add java21 there.
For now, we have a server side allow list for validating runtimes, so it is safe to relax the constraint on this client side.
Thanks!
@ludoch
Copy link
Collaborator Author

ludoch commented Sep 25, 2023 •
edited
Loading

Everything else should be the same, but e2e tests will confirm this.
Also, a new Cloud CLI will be pushed soon to enable this runtime Id as well.

meltsufin added a commit that referenced this issue Sep 26, 2023
@meltsufin
feat: support for java17 and java21 runtimes
2965b7a 
Fixes: #935.
@meltsufin meltsufin mentioned this issue Sep 26, 2023
Merged
meltsufin added a commit that referenced this issue Sep 27, 2023
@meltsufin
feat: support for java17 and java21 runtimes (#936)
8dd95c4 
Fixes: #935.

Co-authored-by: Clément Denis <clement@altirnao.com>
JoeWang1127 pushed a commit that referenced this issue Nov 29, 2023
@meltsufin
feat: support for java17 and java21 runtimes (#936)
c6b6a6d 
Fixes: #935.

Co-authored-by: Clément Denis <clement@altirnao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
p2 type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for java17 and java21 runtimes GoogleCloudPlatform/appengine-plugins
3 participants
@ludoch @meltsufin @JoeWang1127