assign a static field for "0.0.0.0" string

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
GoogleCloudPlatform · Nov 19, 2024 · a9e0ea5 · a9e0ea5
1 parent a54e790
commit a9e0ea5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/runtime/impl/src/main/java/com/google/apphosting/runtime/AppEngineConstants.java b/runtime/impl/src/main/java/com/google/apphosting/runtime/AppEngineConstants.java
@@ -109,6 +109,8 @@ public final class AppEngineConstants {
   //     (<internal20>)
   public static final String WARMUP_IP = "0.1.0.3";
 
+  public static final String UNSPECIFIED_IP = "0.0.0.0";
+
   public static final String DEFAULT_SECRET_KEY = "secretkey";
 
   public static final String ENVIRONMENT_ATTR = "appengine.environment";

diff --git a/...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/http/JettyRequestAPIData.java b/...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/http/JettyRequestAPIData.java
@@ -23,6 +23,7 @@
 import static com.google.apphosting.runtime.AppEngineConstants.IS_TRUSTED;
 import static com.google.apphosting.runtime.AppEngineConstants.PRIVATE_APPENGINE_HEADERS;
 import static com.google.apphosting.runtime.AppEngineConstants.SKIP_ADMIN_CHECK_ATTR;
+import static com.google.apphosting.runtime.AppEngineConstants.UNSPECIFIED_IP;
 import static com.google.apphosting.runtime.AppEngineConstants.WARMUP_IP;
 import static com.google.apphosting.runtime.AppEngineConstants.WARMUP_REQUEST_URL;
 import static com.google.apphosting.runtime.AppEngineConstants.X_APPENGINE_API_TICKET;
@@ -307,12 +308,12 @@ public SocketAddress getRemoteSocketAddress() {
 
               @Override
               public HostPort getServerAuthority() {
-                return new HostPort("0.0.0.0", 0);
+                return new HostPort(UNSPECIFIED_IP, 0);
               }
 
               @Override
               public SocketAddress getLocalSocketAddress() {
-                return InetSocketAddress.createUnresolved("0.0.0.0", 0);
+                return InetSocketAddress.createUnresolved(UNSPECIFIED_IP, 0);
               }
             };
           }

diff --git a/...e_impl_jetty9/src/main/java/com/google/apphosting/runtime/jetty9/JettyRequestAPIData.java b/...e_impl_jetty9/src/main/java/com/google/apphosting/runtime/jetty9/JettyRequestAPIData.java
@@ -23,6 +23,7 @@
 import static com.google.apphosting.runtime.AppEngineConstants.IS_TRUSTED;
 import static com.google.apphosting.runtime.AppEngineConstants.PRIVATE_APPENGINE_HEADERS;
 import static com.google.apphosting.runtime.AppEngineConstants.SKIP_ADMIN_CHECK_ATTR;
+import static com.google.apphosting.runtime.AppEngineConstants.UNSPECIFIED_IP;
 import static com.google.apphosting.runtime.AppEngineConstants.WARMUP_IP;
 import static com.google.apphosting.runtime.AppEngineConstants.WARMUP_REQUEST_URL;
 import static com.google.apphosting.runtime.AppEngineConstants.X_APPENGINE_API_TICKET;
@@ -335,7 +336,7 @@ public String getRemoteAddr() {
 
           @Override
           public String getServerName() {
-            return "0.0.0.0";
+            return UNSPECIFIED_IP;
           }
 
           @Override
@@ -350,12 +351,12 @@ public int getRemotePort() {
 
           @Override
           public String getLocalName() {
-            return "0.0.0.0";
+            return UNSPECIFIED_IP;
           }
 
           @Override
           public String getLocalAddr() {
-            return "0.0.0.0";
+            return UNSPECIFIED_IP;
           }
 
           @Override

diff --git a/...e/runtime_impl_jetty9/src/main/java/com/google/apphosting/runtime/jetty9/RpcEndPoint.java b/...e/runtime_impl_jetty9/src/main/java/com/google/apphosting/runtime/jetty9/RpcEndPoint.java
@@ -16,6 +16,8 @@
 
 package com.google.apphosting.runtime.jetty9;
 
+import static com.google.apphosting.runtime.AppEngineConstants.UNSPECIFIED_IP;
+
 import com.google.apphosting.base.protos.RuntimePb.UPRequest;
 import com.google.apphosting.base.protos.RuntimePb.UPResponse;
 import com.google.apphosting.runtime.MutableUpResponse;
@@ -55,7 +57,7 @@ public MutableUpResponse getUpResponse() {
 
   @Override
   public InetSocketAddress getLocalAddress() {
-    return InetSocketAddress.createUnresolved("0.0.0.0", 0);
+    return InetSocketAddress.createUnresolved(UNSPECIFIED_IP, 0);
   }
 
   @Override