This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Resolve GCLOUD_CONFIG/APPENGINE_CONFIG late #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user doesn't have the cloud sdk installed yet, but uses GCLOUD_CONFIG, it results in a cloud sdk not found error. While this seems like a strange case, it's safest for us to only even attempt anything after we can guarantee the cloud sdk is setup.
chanseokoh
reviewed
Jan 8, 2019
src/main/java/com/google/cloud/tools/gradle/appengine/core/DeployExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/tools/gradle/appengine/standard/AppEngineStandardPlugin.java
Outdated
Show resolved
Hide resolved
.../java/com/google/cloud/tools/gradle/appengine/standard/StandardDeployTargetResolverTest.java
Outdated
Show resolved
Hide resolved
coollog
approved these changes
Jan 9, 2019
| } | ||
|
|
||
| /** | ||
| * Process user configuration of "projectId". If not configured or set to APPENGINE_CONFIG (not | ||
| * allowed for app.yaml based projects), show usage. If set to GCLOUD_CONFIG then read from | ||
| * gcloud's global state. If set but not a keyword then just return the set value. | ||
| */ | ||
| @Override | ||
| public String getProject(String configString) { | ||
| if (configString == null | ||
| || configString.trim().isEmpty() | ||
| || configString.equals(APPENGINE_CONFIG)) { | ||
| throw new GradleException(PROJECT_ERROR); | ||
| } else if (configString.equals(GCLOUD_CONFIG)) { |
There was a problem hiding this comment.
oh yeah, weird that I did that, must be losing my mind.
chanseokoh
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user doesn't have the cloud sdk installed yet, but uses
GCLOUD_CONFIG, it results in a cloud sdk not found error.
While this seems like a strange case, it's safest for us
to only even attempt anything after we can guarantee the cloud
sdk is setup.