This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Fix UP-TO-DATE annotations #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Input -> InputFiles on dockerFile for appengine-web.xml staging. - InputFiles on extraFilesDirectory method renamed to an actual getter. - Also renames the configuration generater to actual name.
|
I'm not sure how to write a test for this. The gradle source doesn't have much testing for this, so I'm a little confused. Added a question to the gradle forums: https://discuss.gradle.org/t/how-do-i-write-a-test-to-validate-my-use-of-inputfiles-or-any-other-types-of-up-to-date-annotations/30067 |
TadCordle
previously approved these changes
Jan 3, 2019
src/test/java/com/google/cloud/tools/gradle/appengine/appyaml/StageAppYamlExtensionTest.java
Show resolved
Hide resolved
|
@TadCordle @chanseokoh updated with a test, PTAL. |
TadCordle
reviewed
Jan 4, 2019
| @@ -16,15 +16,23 @@ | |||
|
|
|||
| package com.google.cloud.tools.gradle.appengine.appyaml; | |||
|
|
|||
| import static org.gradle.testkit.runner.TaskOutcome.SUCCESS; | |||
There was a problem hiding this comment.
Should we be using static imports?
TadCordle
approved these changes
Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318.
getter.