This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Convert to static extension building #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from dynamic extension populating to the usual way of static extensions and nested configuration objects for core flex and standard features. The experimental source-context plugin still adds to the appengine configuration dynamically.
coollog
reviewed
Feb 7, 2018
| @@ -41,6 +42,7 @@ | |||
| private String version; | |||
| private File appEngineDirectory; | |||
|
|
|||
| @Inject | |||
There was a problem hiding this comment.
Oh yeah I accidentally left that in there, with new versions of gradle, if you created an extension from the root, gradle would ask you to inject the params instead of passing them in.
|
|
||
| /** | ||
| * Create nested configuration blocks as Extensions. Gradle 4.5 has an ObjectFactory class to deal | ||
| * with this, transition to that when upgrading gradle version. |
There was a problem hiding this comment.
Maybe have this be in a TODO?
| import org.gradle.util.GradleVersion; | ||
|
|
||
| /** | ||
| * Core plugin for App Engine, contains common tasks like deploy and show configuration Also | ||
| * instantiates the "tools" extension to specify the cloud sdk path. | ||
| */ | ||
| public class AppEngineCorePlugin implements Plugin<Project> { | ||
| public class AppEngineCorePluginConfiguration { |
There was a problem hiding this comment.
APP_ENGINE_TASK_GROUP seems to be unused now.
| @@ -42,27 +40,27 @@ | |||
| public static final String STAGE_EXTENSION = "stage"; | |||
There was a problem hiding this comment.
STAGE_EXTENSION seems to be unused now.
|
|
||
| /** Create nested configuration blocks as Extensions. */ | ||
| public void createSubExtensions(Project project) { | ||
| tools = ((ExtensionAware) this).getExtensions().create("tools", ToolsExtension.class, project); |
There was a problem hiding this comment.
Might be good to place "tools", "deploy", and "stage" in constants.
coollog
approved these changes
Feb 8, 2018
|
Great to see this being merged. Is there an ETA on the release of the next version of the plugin including this? |
|
I would say by end of week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from dynamic extension populating to the usual way
of static extensions and nested configuration objects for core
flex and standard features.
The experimental source-context plugin still adds to the appengine
configuration dynamically.