This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Dev App Server v1 integration #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loosebazooka
commented
Apr 6, 2017
•
- Services replaces AppYamls (setting AppYamls reveals deprecation warning)
- By default, we use dev appserver v1
- users can swap between v1 and v2 by setting
akerekes
reviewed
Apr 6, 2017
| String serverVersion = run.getServerVersion(); | ||
| validator.validateServerVersion(serverVersion); | ||
|
|
||
| if (V1.equals(serverVersion)) { |
There was a problem hiding this comment.
You could use switch instead
|
|
||
| DefaultStopConfiguration stop = new DefaultStopConfiguration(); | ||
|
|
||
| if (V1.equals(serverVersion)) { |
There was a problem hiding this comment.
You could use switch instead
| void validateServerVersion(String serverVersion) throws ProjectConfigurationException { | ||
| if (!SERVER_VERSIONS.contains(serverVersion)) { | ||
| throw new ProjectConfigurationException( | ||
| "Invalid serverVersion '" + serverVersion + "' please use " + SERVER_VERSIONS, |
| @@ -76,94 +76,14 @@ public void testDeploy_taskTree() throws IOException { | |||
| .withArguments("appengineDeploy", "--dry-run") | |||
| .build(); | |||
|
|
|||
| final List<String> expected = ImmutableList | |||
| .of(":compileJava", ":processResources", ":classes", ":war", ":explodeWar", ":assemble", | |||
| final List<String> expected = Arrays | |||
There was a problem hiding this comment.
I dont' know? I'll change this back
akerekes
approved these changes
Apr 6, 2017
| public TemporaryFolder tmpDir = new TemporaryFolder(); | ||
|
|
||
| @Rule | ||
| public ExpectedException exception = ExpectedException.none(); |
There was a problem hiding this comment.
If you don't expect exceptions, they you don't need this field.
| return null; | ||
| @Deprecated | ||
| public void setAppYamls(Object appYamls) { | ||
| project.getLogger().warn("'appYamls' is deprecated, this parameter will set 'services'. Please use 'services' in the future."); |
- Services replaces AppYamls (setting AppYamls reveals deprecation warning)
- By default, we use dev appserver v1
- users can swap between v1 and v2 by setting
appengine {
run {
serverVersion = "1" or "2-alpha"
}
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.