chore: enable cgo and use google buildbase #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f8826d to
70e2348
Compare
bernot-dev
reviewed
Mar 21, 2024
cgo needs to be enabled to link against boringcrypto, so we add that here. In addition, we use the google-go.pkg.dev/golang image as the Go buildbase to ensure build-time requirements, like boringcrypto, are enabled. We also use gke.gcr.io/gke-distroless/libc as our runtime image. We add the "cryp/tls/fipsonly" import to ensure boringcrypto is linking properly at build time. We guard this with a build tag "boring" in a dedicated file. Finally, we move away from promu in our Dockerfile as it was not obvious how to pass a go build tag through just in the Docker case. We remove amtool from the image, as its not intended to be used. This involved mimicing a lot of what we do in the Prometheus fork's Dockerfile. Signed-off-by: Daniel Clark <danielclark@google.com>
432f9c8 to
e4ec7f4
Compare
TheSpiritXIII
approved these changes
Mar 29, 2024
This was referenced Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgo needs to be enabled to link against boringcrypto, so we add that
here.
In addition, we use the google-go.pkg.dev/golang image as the Go
buildbase to ensure build-time requirements, like boringcrypto, are
enabled.
We also use gke.gcr.io/gke-distroless/libc as our runtime image.
We add the "cryp/tls/fipsonly" import to ensure boringcrypto is
linking properly at build time. We guard this with a build tag
"boring" in a dedicated file.
Finally, we move away from promu in our Dockerfile as it was not obvious
how to pass a go build tag through just in the Docker case. We remove
amtool from the image, as its not intended to be used. This involved
mimicing a lot of what we do in the Prometheus fork's Dockerfile.