-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetstream Autoscaling Guide #703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bslabe123
requested review from
achandrasekar,
ahg-g and
annapendleton
as code owners
June 13, 2024 21:50
tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md
Show resolved
Hide resolved
annapendleton
approved these changes
Jun 14, 2024
/hold please don't merge before I take a look, thanks |
liurupeng
reviewed
Jun 14, 2024
tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md
Show resolved
Hide resolved
liurupeng
reviewed
Jun 14, 2024
tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md
Outdated
Show resolved
Hide resolved
liurupeng
reviewed
Jun 14, 2024
tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md
Show resolved
Hide resolved
liurupeng
reviewed
Jun 14, 2024
...tstream/maxtext/single-host-inference/terraform/custom-metrics-stackdriver-adapter/README.md
Outdated
Show resolved
Hide resolved
I feel we have added a bunch of files in order to use terraform to deploy the resources for HPA instead of deploying the pod monitoring and cmsa with yamls, what's the benefits going with this approach? @Bslabe123 |
liurupeng
reviewed
Jun 14, 2024
tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md
Show resolved
Hide resolved
…gle-host-inference/README.md Co-authored-by: RupengLiu <rupliu@google.com>
…latform/ai-on-gke into jetstream-terraform
rsgowman
reviewed
Jun 17, 2024
...jetstream/maxtext/single-host-inference/terraform/custom-metrics-stackdriver-adapter/main.tf
Show resolved
Hide resolved
/gcbrun |
liurupeng
approved these changes
Jun 17, 2024
/gcbrun |
leroyjb
pushed a commit
to leroyjb/ai-on-gke
that referenced
this pull request
Jan 24, 2025
* first commit * missing files * various improvements * some autoscaling changes for testing * add targetlabels to podmonitoring * Revert repo pinning * more reversions * more reversions * cleanup * more cleanup * Added to README * revert topology change * tweaks to deployment * HPA terraform fixes * remove stray comment * Add more to README * parameterize metrics scrape port * Cleaned up readme * readme tweak * typo * remove indentation * newline * More updates to readme * change wording * Update metrics scrape example * remove annotation * terraform format * missing comma * maxengine-server in terraform * wording * terraform fmt * parameterize container images * wording * remove ksa var * move deployment to kubectl directory * App -> app * pipe from maxengine module to main * Update tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/README.md Co-authored-by: RupengLiu <rupliu@google.com> * remove TODO * HPA can now scale with HBM --------- Co-authored-by: RupengLiu <rupliu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.