Windows on GCE #338
Merged
Windows on GCE #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please. |
| if FLAGS.os_type == benchmark_spec.WINDOWS: | ||
| valid_benchmarks = windows_benchmarks.VALID_BENCHMARKS | ||
| else: | ||
| valid_benchmarks = benchmarks.VALID_BENCHMARKS |
There was a problem hiding this comment.
Line 163 below - can you expand the error message to say "benchmark %s not valid on %platform"?
7c08604 to
39762d9
Compare
| @@ -157,7 +162,10 @@ def __init__(self, benchmark_info): | |||
| self.project = FLAGS.project | |||
| defaults = DEFAULTS[self.cloud] | |||
| self.zones = FLAGS.zones or [defaults[ZONE]] | |||
| self.image = FLAGS.image or defaults[IMAGE] | |||
| if FLAGS.os_type == WINDOWS: | |||
| self.image = FLAGS.image or defaults.get(WINDOWS_IMAGE) | |||
There was a problem hiding this comment.
I think this would be a lot cleaner if each cloud provider had a {os_type: default_image} map. Currently, would setting --os_type=rhel still install Ubuntu if you don't separately override --image?
There was a problem hiding this comment.
Fixed in another PR
|
Overall I think it looks ok, though I don't know enough about Windows scripting to make meaningful comments on that. As discussed offline, at some point it would be nice to replace various |
f4a4263 to
79cf0a8
Compare
|
PTAL |
|
Looks good as far as overall integration is concerned, can't really comment on the Windows specific side including @ivansmf 's comments. Please flatten the changes before merging, should avoid having "respond to review comments" commits in the main branch history. |
f931117 to
447aa8e
Compare
klausw
added a commit
that referenced
this pull request
Jul 9, 2015
Release 0.18.0. (See also #369 which includes this change log with clickable GH-* links.) * New features: * Support OpenStack as cloud provider (GH-305, GH-353, thanks @kivio and @mateusz-blaszkowski) * Support Rackspace as cloud provider (GH-336, thanks @meteorfox and @jrperritt) * Add support for ContainerizedVM using docker exec (GH-333, thanks @gablg1) * Windows guest VM support on Static VM (GH-350), Azure (GH-349, GH-374), AWS (GH-347), and GCE (GH-338) * Add NTttcp Windows networking benchmark (GH-348) * Enhancements: * Support using proxies in VMs (GH-339, GH-337, thanks @kivio) * Enable optional migration on GCE (GH-343) * Execute long running commands via a remote agent (GH-310) * Add resource creation/deletion times to logs (GH-316) * Bugfixes and maintenance updates: * Update PKB to work with Azure version 0.9.3 (GH-312) * Fix AWS CLI usage on Windows host (GH-313) * Auto-fetch AMI IDs for AWS images (GH-364) * Fix publisher missing info for default image and machine type (GH-357) * Fix 'no attribute pkb_thread_log_context' error for sub-thread logs (GH-322) * Benchmark-specific changes: * aerospike: config/flag handling bugfixes (GH-367, GH-360, GH-354) * cassandra_ycsb: move num_vms prerequisite check * fio: add latency percentiles for results (GH-344) * hadoop_terasort: Fix bad SSH option (GH-328) * iperf: add lower bounds to arguments (GH-314) * iperf: add timeout to parallel benchmark runs to handle iperf hangs (GH-375) * netperf: Support confidence intervals, increase test length, report stddev (GH-317, GH-306) * ycsb: Drop unaggregatable results from samples (GH-324) * Development and testing: * **Breaking Change** Automated testing now uses `tox` (GH-330) * Refactored hook scripts, including new opt-in pre-push hook (GH-363) * Use travis for CI testing (GH-340) * Speed up tests using timeouts (GH-299) * Internals: * Move defaults from benchmark_spec to VM classes, move network instantiation out of benchmark spec (GH-342) * Add event hook support (GH-315) * Refactor VM classes (GH-321)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.