Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing project id for spanner-staging-tests and run on spanner runners #2127

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Changing project id for spanner-staging-tests and run on spanner runners #2127

merged 7 commits into from
Jan 17, 2025

Conversation

darshan-sj
Copy link
Contributor

@darshan-sj darshan-sj commented Jan 10, 2025 •
edited
Loading

No description provided.

@darshan-sj darshan-sj marked this pull request as ready for review January 10, 2025 17:34
@manitgupta
Copy link
Member

I see that no Spanner tests have been run on this PR.

  1. Should we include the workflow definition files (.github) in the file list that triggers the Spanner tests?
  2. Without that, how do we verify if the spanner tag is correctly set up and will work?

@darshan-sj
Copy link
Contributor Author

I see that no Spanner tests have been run on this PR.

  1. Should we include the workflow definition files (.github) in the file list that triggers the Spanner tests?
  2. Without that, how do we verify if the spanner tag is correctly set up and will work?

I have run the spanner staging workflow on this branch manually and verified that they are running on spanner instances - https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/spanner-staging-tests.yml

I have also configured this workflow to run if there are any changes to the config file itself. It did not get triggered for this PR.

@darshan-sj darshan-sj force-pushed the spanner-staging-tests branch from 2ce219e to 4850e03 Compare January 16, 2025 06:27
@darshan-sj darshan-sj force-pushed the spanner-staging-tests branch from 4850e03 to 45cc8b0 Compare January 16, 2025 06:41
@darshan-sj darshan-sj merged commit f2abe93 into main Jan 17, 2025
8 checks passed
@darshan-sj darshan-sj deleted the spanner-staging-tests branch January 17, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharadwaj-aditya bharadwaj-aditya bharadwaj-aditya left review comments

@manitgupta manitgupta manitgupta approved these changes

@Deep1998 Deep1998 Awaiting requested review from Deep1998

Assignees
No one assigned
Labels
ignore-for-release size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshan-sj @manitgupta @bharadwaj-aditya