Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Beam 2.55.1 #1366

Closed
wants to merge 2 commits into from
Closed

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Mar 14, 2024

No description provided.

@Abacn
Copy link
Contributor Author

Abacn commented Mar 15, 2024

Still failing for the same reason as #1361, even though rc2 fixed org.hamcrest dependency. Found the cause is due to maven logic: https://stackoverflow.com/questions/75333105/maven-test-dependency-removes-transitive-compile-dependency-from-uberjar

So still need to move hamcrest dependency to from test to compile

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 15, 2024
@Abacn Abacn closed this Apr 10, 2024
@Abacn Abacn deleted the validate_2_55_rc2 branch April 10, 2024 14:15
@Abacn Abacn restored the validate_2_55_rc2 branch April 10, 2024 18:55
@Abacn Abacn reopened this Apr 10, 2024
@Abacn Abacn force-pushed the validate_2_55_rc2 branch from 0b7da3a to c2b1abd Compare April 10, 2024 18:56
@pull-request-size pull-request-size bot added size/S and removed size/M labels Apr 10, 2024
@Abacn Abacn changed the title [Do not merge] Beam 2.55.0RC2 validation Test Beam 2.55.1 Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #1366 (c2b1abd) into main (02f67b8) will increase coverage by 0.01%.
Report is 14 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head c2b1abd differs from pull request most recent head 46b56fb. Consider uploading reports for the commit 46b56fb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1366      +/-   ##
============================================
+ Coverage     38.97%   38.99%   +0.01%     
- Complexity     2789     2790       +1     
============================================
  Files           743      743              
  Lines         42028    42022       -6     
  Branches       4530     4529       -1     
============================================
+ Hits          16381    16386       +5     
+ Misses        24148    24139       -9     
+ Partials       1499     1497       -2     
Components Coverage Δ
spanner-templates 52.39% <ø> (-0.02%) ⬇️
spanner-import-export 65.51% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 56.23% <ø> (ø)
spanner-live-reverse-replication 37.53% <ø> (ø)
spanner-bulk-migration 58.12% <ø> (ø)
Files Coverage Δ
.../apache/beam/sdk/io/gcp/spanner/SpannerConfig.java 27.86% <0.00%> (-0.95%) ⬇️

... and 9 files with indirect coverage changes

@Abacn Abacn force-pushed the validate_2_55_rc2 branch from c2b1abd to 46b56fb Compare April 11, 2024 14:31
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 11, 2024
@Abacn Abacn closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant