feat: implement capabilities handling in session.new #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72b1e9a to
4b3cbc2
Compare
4b3cbc2 to
b873713
Compare
941b12c to
b18470c
Compare
Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com>
Lightning00Blade
approved these changes
Aug 1, 2024
OrKoN
pushed a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.4](chromium-bidi-v0.6.3...chromium-bidi-v0.6.4) (2024-08-05) ### Features * implement capabilities handling in session.new ([#2448](#2448)) ([9c74a9c](9c74a9c)) ### Bug Fixes * do not log env ([#2471](#2471)) ([048fed1](048fed1)) * improve capabilities matching ([#2464](#2464)) ([8181e44](8181e44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Mapper options to be processed inside session.new so that there is a single place on how these options have to be provided and that allows using the mapper in the same way as other protocol implementations.
ChromeDriver issue: https://crbug.com/356371297