Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themeColorDark aka colorPrimaryDark aka STATUS_BAR_COLOR_DARK #816

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

khmyznikov
Copy link
Contributor

@khmyznikov khmyznikov commented Jul 29, 2023

Added customtabs.trusted.STATUS_BAR_COLOR_DARK.

Fixes #802

@google-cla
Copy link

google-cla bot commented Jul 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you for the PR. I dropped a couple request changes to ensure this works with existing TWA Manifests.

packages/core/src/lib/TwaManifest.ts Outdated Show resolved Hide resolved
packages/core/src/lib/TwaManifest.ts Outdated Show resolved Hide resolved
khmyznikov and others added 2 commits July 31, 2023 17:21
Co-authored-by: André Cipriani Bandarra <andreban@gmail.com>
Co-authored-by: André Cipriani Bandarra <andreban@gmail.com>
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you very much!

@andreban andreban merged commit 33d83d0 into GoogleChromeLabs:main Aug 1, 2023
@khmyznikov
Copy link
Contributor Author

khmyznikov commented Aug 1, 2023

@SayedElabady Could you please create a new release that includes this change. I'm planning to add integration of the new field to PWABuilder.

@GCSBOSS
Copy link

GCSBOSS commented Aug 1, 2023

@SayedElabady need this in release. I will add integration of new field with PWABuilder.

Waiting to know when this gets releases on PWABuilder /o/

@andreban
Copy link
Member

andreban commented Aug 7, 2023

@khmyznikov @GCSBOSS This has been deployed on Bubblewrap 1.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override theme color for dark mode
3 participants