-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add themeColorDark aka colorPrimaryDark aka STATUS_BAR_COLOR_DARK #816
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you for the PR. I dropped a couple request changes to ensure this works with existing TWA Manifests.
Co-authored-by: André Cipriani Bandarra <andreban@gmail.com>
Co-authored-by: André Cipriani Bandarra <andreban@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you very much!
@SayedElabady Could you please create a new release that includes this change. I'm planning to add integration of the new field to PWABuilder. |
Waiting to know when this gets releases on PWABuilder /o/ |
@khmyznikov @GCSBOSS This has been deployed on Bubblewrap 1.21.0 |
Added customtabs.trusted.STATUS_BAR_COLOR_DARK.
Fixes #802