Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips BOM on Web Manifests #685

Merged
merged 1 commit into from
Apr 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/lib/TwaGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export class TwaGenerator {
}

// We're writing as a string, but attempt to convert to check if it's a well-formed JSON.
const webManifestJson = await response.json();
const webManifestJson = JSON.parse((await response.text()).trim());

// We want to ensure that "start_url" is the same used to launch the Trusted Web Activity.
webManifestJson['start_url'] = twaManifest.startUrl;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/lib/TwaManifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ export class TwaManifest {
*/
static async fromWebManifest(url: string): Promise<TwaManifest> {
const response = await fetchUtils.fetch(url);
const webManifest = await response.json();
const webManifest = JSON.parse((await response.text()).trim());
const webManifestUrl: URL = new URL(url);
return TwaManifest.fromWebManifestJson(webManifestUrl, webManifest);
}
Expand Down