Update JDK 8 to JDK 11 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the JDK used to match the JDK that is currently distributed by Android Studio. This would help keep the building of Android apps consistent between Android Studio and Bubblewrap. Additionally, this unlocks the ability for bubblewrap to support keystores that utilize aes encrypted keys.
|
Additional notes:
|
|
Just to double check, you've testing This LGTM if it works. |
|
@PEConn - Yes, tested building and signing on Linux. Haven't been able to test alternative platforms |
PEConn
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the JDK used to match the JDK that is currently distributed
by Android Studio. This would help keep the building of Android apps
consistent between Android Studio and Bubblewrap. Additionally, this
unlocks the ability for bubblewrap to support keystores that utilize
aes encrypted keys.