Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --manifest option for build script #472

Merged

Conversation

jdecked
Copy link
Contributor

@jdecked jdecked commented Feb 25, 2021

Problem: The directory with our twa-manifest.json and the directory we're running the Bubblewrap commands from are different.

Solution: Add a --manifest option to the bubblewrap build command which allows the user to specify a directory where the client should look for twa-manifest.json, much like that option for the bubblewrap update command.

@andreban andreban added the enhancement New feature or request label Feb 25, 2021
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you very much for this!

@andreban andreban merged commit 2eee55a into GoogleChromeLabs:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants