Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename classConstructor to onCreate. #412

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Rename classConstructor to onCreate. #412

merged 1 commit into from
Nov 27, 2020

Conversation

PEConn
Copy link
Collaborator

@PEConn PEConn commented Nov 27, 2020

This PR follows up from #410 and makes the variable name a bit more apt.

@PEConn PEConn requested a review from andreban November 27, 2020 09:26
andreban
andreban approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the follow-up PR!

@andreban andreban merged commit f9b78eb into master Nov 27, 2020
@andreban andreban deleted the RenameClassConstructor branch June 7, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PEConn @andreban