New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Web share target support - string resources save" #381

Closed

andreban wants to merge 1 commit into master from revert-377-stringResource

Member

andreban commented Oct 28, 2020 •

edited

Loading

Reverts #377

This PR is broken for a couple of reasons:

twaManifest.webSharedoesn't exist.
Usually, we'd use webShare directly (see other variables), but that's not defined in TwaManifesteither.

        <% if (twaManifest.webShare) { %>
            // The data for the app to support web share target.
            resValue "string", "webShare", twaManifest.webShare
        <% } %>


          Revert "Web share target support - string resources save"

44b997c

andreban requested a review from PEConn

October 28, 2020 13:42

andreban closed this

andreban deleted the revert-377-stringResource branch

June 7, 2021 13:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet