Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Chrome OS only flag to init. #351

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

nohe427
Copy link
Collaborator

@nohe427 nohe427 commented Oct 1, 2020

It was brought to my attention that most developers pursuing bubblewrap
would already know that they want to specify a ChromeOS only build. This
allows those developers to specify ChromeOS only from the beginning,
preventing them from needing to go back and modify the TWA-Manifest file
later on.

It was brought to my attention that most developers pursuing bubblewrap
would already know that they want to specify a ChromeOS only build. This
allows those developers to specify ChromeOS only from the beginning,
preventing them from needing to go back and modify the TWA-Manifest file
later on.
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@andreban andreban merged commit 68508f7 into GoogleChromeLabs:master Oct 2, 2020
@andreban andreban added the enhancement New feature or request label Oct 13, 2020
@nohe427 nohe427 deleted the init-chromeos-only branch April 7, 2021 18:29
@nohe427 nohe427 restored the init-chromeos-only branch April 7, 2021 18:29
@nohe427 nohe427 deleted the init-chromeos-only branch April 7, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants