Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix app shortcuts to not fail with "app isn't installed" error #346

Closed
wants to merge 1 commit into from

Conversation

dylanwenzlau
Copy link

Tried quite a few things to get the shortcuts to work with bubblewrap as created from imgflip.com/manifest.json, but nothing worked even though they work fine when installed as a standard progressive web app. This targetClass seemed out of place and changing it finally made the shortcuts work when testing locally with bubblewrap install.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dylanwenzlau
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@andreban
Copy link
Member

Thanks for checking this out. There's an issue filed for this at #335 and a PR at #345 that fixes it. It implements exactly the same changed you implemented - so, work is not wasted and it does confirm that the change does indeed fixes the issue. Thank you.

@dylanwenzlau
Copy link
Author

Oh wow, didn't expect there to have been a fix sitting around in pull requests. I did check through the latest commits on master for a fix but didn't see anything. Figured the fix was so fast and tiny that it would have been instantly merged.

@andreban
Copy link
Member

Yeah, I wrote the pull-request on Saturday morning - It's weekend, so others haven't had a chance to take a look and approve yet.

@andreban
Copy link
Member

Duplicate of #345

Closing this as a duplicate of #345. Thanks for checking this out and creating the PR!

@andreban andreban closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants