Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved MockLog to lib/mock #329

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Moved MockLog to lib/mock #329

merged 1 commit into from
Sep 8, 2020

Conversation

andreban
Copy link
Member

@andreban andreban commented Sep 8, 2020

Exporting MockLog from spec causes Bubblewrap to crash when installed from NPM:

twa-bootstrap on  master [$] via ⬢ v10.19.0 
❯ npx @bubblewrap/cli 
npx: installed 171 in 7.546s
Cannot find module './spec/mock/MockLog'

Moved it to `lib/mock' instead.

@andreban andreban merged commit 1ea472a into GoogleChromeLabs:master Sep 8, 2020
@andreban andreban added the bug Something isn't working label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

@chenlevy24 chenlevy24 Awaiting requested review from chenlevy24

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreban @PEConn