Fixed reading shortcuts from twa manifest #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`update` was crashing with method not found: `assetName`. Loading the JSON from the file doesn't automatically assign methods to the shortcut. So, we create proper shortcuts when creating the TwaManifest from the JSON.
- data.shortcuts can be undefined. - Expect a ShortchutInfo[] on constructor.
PEConn
approved these changes
Sep 8, 2020
| @@ -153,7 +153,10 @@ export class TwaManifest { | |||
| this.signingKey = data.signingKey; | |||
| this.appVersionName = data.appVersion; | |||
| this.appVersionCode = data.appVersionCode || DEFAULT_APP_VERSION_CODE; | |||
| this.shortcuts = data.shortcuts; | |||
| this.shortcuts = (data.shortcuts || []).map((si) => { | |||
There was a problem hiding this comment.
Huh, this line is quite neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatewas crashing with method not found:assetName. Loadingthe JSON from the file doesn't automatically assign methods to
the shortcut. So, we create proper shortcuts when creating the
TwaManifest from the JSON.