Added the rmdir method
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is used to delete a file or directory hierarchy and will be used to clean an existing project before regenerating it.
PEConn
reviewed
Sep 8, 2020
Comment on lines
+242
to
+243
| // This is a directory. We delete files and sub directories inside it, then delete the | ||
| // directory itself. |
There was a problem hiding this comment.
Why? What breaks if you just delete the directory?
There was a problem hiding this comment.
Node 12 has a recursive option when deleting directories. Node 10 doesn't, and rmdir fails.
- stat fails on MacOs when the file doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used to delete a file or directory hierarchy and
will be used to clean an existing project before regenerating it.
More context in #326